Re: [www-devel] Patches for libepubgen to support writing-mode support

Hi Mark,

On Mon, Mar 26, 2018 at 10:37:52AM +0200, Miklos Vajna <vmiklos@collabora.co.uk> wrote:
> Hi Mark,
>
> On Sun, Mar 25, 2018 at 11:13:30PM +0800, Mark Hung <marklh9@gmail.com> wrote:
> > 0001-Support-writing-mode-for-reflowable-layout-method.patch
>
> I've merged this one, thanks. As a follow-up patch, you might want to
> create a dedicated EPUBBodyStyleManager, inheriting from
> EPUBSpanStyleManager so you could avoid this "hack body into span" bool.
> :-)
>
> I'll get to the other 2 patches a bit later.

2nd one is merged, for the 3rd one I get:

make[3]: Entering directory '/home/vmiklos/git/libreoffice/libepubgen/src/lib'
  CXX      EPUBTextGenerator.lo
  CXX      EPUBGenerator.lo
  CXX      EPUBPagedGenerator.lo
  CXX      EPUBSplitGuard.lo
EPUBSplitGuard.cpp: In constructor 
'libepubgen::EPUBSplitGuard::EPUBSplitGuard(libepubgen::EPUBSplitMethod, bool)':
EPUBSplitGuard.cpp:18:87: error: declaration of 'splitOnSecondPageSpan' shadows a member of 'this' 
[-Werror=shadow]
 EPUBSplitGuard::EPUBSplitGuard(const EPUBSplitMethod method,bool splitOnSecondPageSpan)
                                                                                       ^
cc1plus: all warnings being treated as errors

I.e. it's a bit unreadable to use splitOnSecondPageSpan both as a member
function name and also as a parameter name in the constructor, perhaps
rename prefix the member function with "is", since it returns a bool?

Thanks,

Miklos

-- 
To unsubscribe e-mail to: devel+unsubscribe@documentliberation.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.documentliberation.org/www/devel/
All messages sent to this list will be publicly archived and cannot be deleted