[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [www-devel] Patch: Catch the line number where assertCss was called.


Hi Miklos,

Done. The updated patch is here:
https://sourceforge.net/p/libepubgen/tickets/_discuss/thread/d1bdd53a/fe73/attachment/0001-Replace-assertCss-with-CPPUNIT_ASSERT_CSS.patch

2018-04-03 21:18 GMT+08:00 Miklos Vajna <vmiklos@collabora.co.uk>:

> Hi Mark,
>
> Cppunit suggests to write your own assert macros if you want to preserve
> line number information. See libreoffice core.git
> sw/qa/extras/inc/swmodeltestbase.hxx:965 for an example.
>
> Do you think you could rework your patch, so that you add a new
> CPPUNIT_ASSERT_CSS() (or similar) macro, rather than use exceptions?
>
> Thanks,
>
> Miklos
>



--
Mark Hung

--
To unsubscribe e-mail to: devel+unsubscribe@documentliberation.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.documentliberation.org/www/devel/
All messages sent to this list will be publicly archived and cannot be deleted

Follow-Ups:
Re: [www-devel] Patch: Catch the line number where assertCss was called.Miklos Vajna <vmiklos@collabora.co.uk>
Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.