Hi,
I see a recurring pattern: in both librevenge and libepubgen some of the
public headers are not self-contained.
E.g. in libepubgen, inc/libepubgen/libepubgen-decls.h refers to
librevenge::RVNGBinaryData, but it does not forward-declare or include
the relevant header for that class.
I saw a similar problem in librevenge as well. Is this intentional? If
so, perhaps should we document in these non-self-containing header that
the recommended way is to just include libfoo/libfoo.h and not the
individual headers directly?
Or in case there is no problem with that, I would happily make all
public headers self-contained (i.e. fix existing problems by adding
missing forward declarations or failing that, includes). I guess I don't
have to go into details why self-contained headers are good for fast
builds. :-)
Thanks,
Miklos
--
To unsubscribe e-mail to: devel+unsubscribe@documentliberation.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.documentliberation.org/www/devel/
All messages sent to this list will be publicly archived and cannot be deleted
Context
- [www-devel] Non-self-contained headers · Miklos Vajna
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.